fix: preserve nested archives which fail to extract#1383
Merged
stevebeattie merged 1 commit intoFeb 17, 2026
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
nested-archive-persistence
branch
from
074a66c to
51db4da
Compare
stevebeattie
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently remove all nested archives regardless of whether they've been extracted successfully or not. In cases where an archive does not extract successfully, we can instead leave it as-is which will allow malcontent to run a best-effort scan against the archive. This was originally a debug message and is now a warning so that it's much more obvious when this happens.
While this will not be nearly as accurate scanning an archive's constituent files, any scan results are better than no scan at all. This PR also adds two tests to ensure that we align with the expected behavior depending on whether
ExitExtractionis in use or not.